reminisce commented on a change in pull request #9306: Sequence Operator
Improvements
URL: https://github.com/apache/incubator-mxnet/pull/9306#discussion_r160335257
##########
File path: src/operator/sequence_last-inl.h
##########
@@ -74,33 +145,32 @@ class SequenceLastOp : public Operator {
CHECK_EQ(out_data.size(), 1U);
Stream<xpu> *s = ctx.get_stream<xpu>();
+ // only support axis of 0 or 1 for now
+ bool axis = static_cast<bool>(param_.axis);
Review comment:
Defining a bool value for axis is confusing in terms of readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
