reminisce commented on a change in pull request #9306: Sequence Operator
Improvements
URL: https://github.com/apache/incubator-mxnet/pull/9306#discussion_r160334690
##########
File path: src/operator/sequence_last-inl.h
##########
@@ -45,16 +45,46 @@ namespace op {
namespace seq_last {
enum SequenceLastOpInputs { kData, kSequenceLength };
enum SequenceLastOpOutputs { kOut };
+enum SequenceLastOpResource { kTempSpace };
}
struct SequenceLastParam : public dmlc::Parameter<SequenceLastParam> {
bool use_sequence_length;
+ uint32_t axis;
DMLC_DECLARE_PARAMETER(SequenceLastParam) {
DMLC_DECLARE_FIELD(use_sequence_length)
.set_default(false)
.describe(
- "If set to true, this layer takes in an extra input parameter
`sequence_length` "
+ "If set to true, this layer takes in an extra input parameter "
+ "`sequence_length` "
"to specify variable length sequence");
+ DMLC_DECLARE_FIELD(axis).set_default(0).describe(
+ "The sequence axis. Only values of 0 and 1 are current supported.");
+ }
+};
+
+template <int req>
+struct SequenceLastKernel {
+ template <typename DType>
+ MSHADOW_XINLINE static void Map(int i, DType *out, const DType *in,
+ const DType *idx, int offset1, int offset2,
+ mshadow::Shape<2> oshape) {
+ auto opos = mxnet_op::unravel(i, oshape);
+ int seqpos = static_cast<int>(idx[opos[0]]) - 1;
Review comment:
Please add `const` wherever possible, same for all of the following code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
