piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r164206089
########## File path: include/mxnet/c_api.h ########## @@ -227,10 +231,132 @@ MXNET_DLL int MXSetProfilerConfig(int mode, const char* filename); */ MXNET_DLL int MXSetProfilerState(int state); -/*! \brief Save profile and stop profiler */ +/*! + * \brief Save profile and stop profiler + * \param append true if appending to current profile file, false for truncate + * \return 0 when success, -1 when failure happens. + */ MXNET_DLL int MXDumpProfile(); -/*! \brief Set the number of OMP threads to use */ + +/*! + * \brief Print aggregate stats to the console + * \param reset Clear the aggregate stats after printing + * \return 0 when success, -1 when failure happens. + * \note + */ +MXNET_DLL int MXDumpAggregateProfileStats(int reset); Review comment: Would it be better return as string? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
