piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r164207417
########## File path: python/mxnet/profiler.py ########## @@ -20,28 +20,34 @@ # pylint: disable=too-many-branches, too-many-statements """Profiler setting methods.""" from __future__ import absolute_import - import ctypes -from .base import _LIB, check_call, c_str +from .base import _LIB, check_call, c_str, ProfileHandle, c_str_array -def profiler_set_config(mode='symbolic', filename='profile.json'): +def profiler_set_config(flags): Review comment: `**kwargs`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
