cjolivier01 commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170489543
########## File path: include/mxnet/tensor_blob.h ########## @@ -36,8 +36,15 @@ #include <utility> #include <algorithm> #include "./base.h" + namespace mxnet { +// redefine DLPack enumeration to be backward compatible. +const int kCPU = kDLCPU; Review comment: should this be constexpr? what keeps it from generating an integer in the data segment for each file compiled? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services