cjolivier01 commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170513959
########## File path: src/nnvm/tvm_bridge.cc ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm_bridge.cc + * \brief Bridge to run TVM's PackedFunc in MXNet's async engine. + * + * This bridge is mainly used to expose MXNet's async engine push to + * TVM. It only uses TVM runtime in aheader only mode, which means + * there is no link dependencies. + * + * Support for TVM is optional even when this code + * is always compiled and built with the project. + * We choose this strategy because we do not yet want + * llvm as dependency(which TVM uses). So instead we expose hook + * to TVM and let user use this feature when they have TVM installed. + * + * We do require TVM and MXNet to be built with same C++ ABI of std::function + */ +#define TVM_RUNTIME_HEADER_ONLY 1 +#include <tvm/runtime/packed_func.h> +#include <mxnet/c_api.h> +#include <mxnet/ndarray.h> +#include <mxnet/engine.h> + +#include <memory> + +namespace mxnet { + +using tvm::runtime::PackedFunc; +using tvm::runtime::TVMArgs; +using tvm::runtime::TVMRetValue; + +/*! + * \brief Async functor object + * calling argument of the function. + */ +class TVMFunctor { + public: + // constructor + explicit TVMFunctor(PackedFunc func, PackedFunc fset_stream) + : func_(func), fset_stream_(fset_stream) {} + + void Init(const TVMArgs& args, + const std::vector<int>& const_loc, + std::vector<Engine::VarHandle>* const_vars, + std::vector<Engine::VarHandle>* mutate_vars) { + values_.clear(); + type_codes_.clear(); + values_.insert(values_.end(), args.values, args.values + args.size()); + type_codes_.insert( + type_codes_.end(), args.type_codes, args.type_codes + args.size()); + + size_t const_loc_ptr = 0; + for (int i = 0; i < args.size(); ++i) { + if (args.type_codes[i] == kTVMNDArrayTypeCode) { + const NDArray& nd = + static_cast<NDArray*>(args.values[i].v_handle)[0]; + // We cannot set the value until + type_codes_[i] = kArrayHandle; + array_data_.push_back(nd); + array_loc_.push_back(i); + // check if there is read or mutate + // by default assume we mutate the array. + if (const_loc_ptr < const_loc.size() && + i == const_loc[const_loc_ptr]) { + const_vars->push_back(nd.var()); Review comment: ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
