cjolivier01 commented on a change in pull request #9880: TVM bridge support to
JIT NDArray Function by TVM
URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170489831
##########
File path: include/mxnet/tensor_blob.h
##########
@@ -36,8 +36,15 @@
#include <utility>
#include <algorithm>
#include "./base.h"
+
namespace mxnet {
+// redefine DLPack enumeration to be backward compatible.
+const int kCPU = kDLCPU;
+const int kGPU = kDLGPU;
+// extension type code under TVM function.
+const int kTVMNDArrayTypeCode = 19;
Review comment:
mostly because the 19 seems arbitrary? and maybe extensible to other numbers
in the future? in that case, an enum could help to manage accidental overlap.
although my assumptions here may not be correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
