threeleafzerg commented on a change in pull request #10696: [MXNET-366]Extend MXNet Distributed Training by MPI AllReduce URL: https://github.com/apache/incubator-mxnet/pull/10696#discussion_r186004824
########## File path: src/mpi_collectives/src/mpi_collectives.cxx ########## @@ -0,0 +1,827 @@ +/* Review comment: cxx is selected on purpose to solve compilation dependency originally. Our mpi_collectives.cxx depends upon generated mpi_message.pb.cc and mpi_message.pb.h to compile. makefile rule SRC = $(wildcard src/*/*/*/*.cc src/*/*/*.cc src/*/*.cc src/*.cc) will contain mpi_collectives.cc if we don't change the suffix. $SRC has its own compilation rule. mpi related files has another compilation rule. That's why I use different suffix. But I know your concern, I can use makefile built-in function filterout to remove mpi files in SRC. I will change their suffix to cc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
