threeleafzerg commented on a change in pull request #10696: [MXNET-366]Extend
MXNet Distributed Training by MPI AllReduce
URL: https://github.com/apache/incubator-mxnet/pull/10696#discussion_r187496727
##########
File path: Makefile
##########
@@ -382,6 +402,10 @@ else
endif
endif
+MPI_SRC = $(wildcard src/mpi_collectives/src/*.cc)
Review comment:
@szha I know that. SRC_FILTER is put here for future extension. Because
maybe in future, another source code which is put within src/ need different
compilation rule same as MPI_SRC. SRC_FILTER will looks like SRC_FILTER +=
$(wildcard src/[other-component]/src/*.cc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
