threeleafzerg commented on a change in pull request #10696: [MXNET-366]Extend
MXNet Distributed Training by MPI AllReduce
URL: https://github.com/apache/incubator-mxnet/pull/10696#discussion_r187768904
##########
File path: include/mxnet/kvstore.h
##########
@@ -184,6 +184,60 @@ class KVStore {
const std::vector<NDArray*>& values,
int priority = 0) = 0;
+ /*!
+ * \brief push and pull a list of key-value pairs from the all the nodes
+ * It will aggregate the values from all the nodes. It shared the same
+ * syntax as allreduce
+ * \param keys the list of keys
+ * \param in_values the list of buffers to be allreduced
+ * \param out_values the list of buffers to store the result
+ * \param priority Priority of the action
+ */
+ virtual void PushPull(const std::vector<int> &keys,
+ const std::vector<NDArray*> &in_values,
+ const std::vector<NDArray*> &out_values,
+ int priority = 0) {}
Review comment:
OK. I will add them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
