apeforest commented on a change in pull request #11825: Fix non-determinism of
dot(csr.T, dns) = dns with tests
URL: https://github.com/apache/incubator-mxnet/pull/11825#discussion_r203889940
##########
File path: src/operator/tensor/dot-inl.cuh
##########
@@ -35,6 +35,13 @@
namespace mxnet {
namespace op {
+// Returns integer log2(a) rounded up
+inline int log2i(size_t a) {
Review comment:
Although this is only used in this file for now, this function is too
generic and very likely to be used in the future by other developers. Making it
a generic utility will allow us to change its implementation in the future
without breaking existing code. It's output can be cast based on our need. I
don't see it as a reason to have a separate function to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
