apeforest commented on a change in pull request #11825: Fix non-determinism of
dot(csr.T, dns) = dns with tests
URL: https://github.com/apache/incubator-mxnet/pull/11825#discussion_r204478351
##########
File path: src/common/utils.h
##########
@@ -663,6 +663,18 @@ constexpr size_t MaxIntegerValue<mshadow::half::half_t>()
{
return size_t(2) << 10;
}
+MSHADOW_XINLINE int ilog2ul(size_t a) {
Review comment:
Looks good. Please also refactor other places using the same utility as we
discussed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
