apeforest commented on a change in pull request #11825: Fix non-determinism of
dot(csr.T, dns) = dns with tests
URL: https://github.com/apache/incubator-mxnet/pull/11825#discussion_r203891073
##########
File path: src/operator/tensor/dot-inl.cuh
##########
@@ -35,6 +35,13 @@
namespace mxnet {
namespace op {
+// Returns integer log2(a) rounded up
+inline int log2i(size_t a) {
Review comment:
I did a simple search and found log2i (or with slightly different names)
function appeared at least three times in this module. See: indexing_op.h,
pooled_storage_manner.h and intrinsics.cuh. It would be nice to consolidate
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
