haojin2 commented on a change in pull request #12090: [MXNET-791][WIP] Pick with negative indices URL: https://github.com/apache/incubator-mxnet/pull/12090#discussion_r208713090
########## File path: src/operator/tensor/broadcast_reduce_op_index.cc ########## @@ -131,7 +130,7 @@ Examples:: pick(x, y=[0,1], 0) = [ 1., 4.] // picks elements with specified indices along axis 1 - pick(x, y=[0,1,0], 1) = [ 1., 4., 5.] + pick(x, y=[0,-1,0], 1) = [ 1., 4., 5.] Review comment: Please consider adding extra example for the newly supported case instead of modifying the existing cases. For this case maybe you can do ``` pick(x, y=[0,1,0,-1], 1) = [ 1., 4., 5., 4.] ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
