haojin2 commented on a change in pull request #12090: [MXNET-791][WIP] Pick
with negative indices
URL: https://github.com/apache/incubator-mxnet/pull/12090#discussion_r209009729
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -4417,7 +4417,12 @@ def test_pick_helper(index_type=np.int32):
sshape = bshape.copy()
sshape[axis] = 1
data = np.random.uniform(-1, 1, size=bshape)
- index = np.random.randint(0, bshape[axis], size=sshape)
+ mode = np.random.choice(a=['clip', 'wrap'])
Review comment:
Please test both choices for `mode` using a for-loop instead of randomized
testing for `mode`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
