haojin2 commented on a change in pull request #12090: [MXNET-791][WIP] Pick
with negative indices
URL: https://github.com/apache/incubator-mxnet/pull/12090#discussion_r209008339
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -99,6 +99,10 @@ struct ReduceAxisParam : public
dmlc::Parameter<ReduceAxisParam> {
}
};
+namespace pick_ { // to avoid name conflict
+enum TakeOpMode {kRaise, kWrap, kClip};
Review comment:
I would prefer this to be like
```c++
enum PickOpMode {kWrap, kClip};
```
as we do not have `raise` mode at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
