KellenSunderland commented on a change in pull request #11952: [MXNET-707] Add unit test for mxnet to coreml converter URL: https://github.com/apache/incubator-mxnet/pull/11952#discussion_r223325895
########## File path: tools/coreml/test/test_mxnet_converter.py ########## @@ -18,18 +18,16 @@ import unittest import mxnet as mx import numpy as np -import sys -import os -current_working_directory = os.getcwd() -sys.path.append(current_working_directory + "/..") -sys.path.append(current_working_directory + "/../converter/") -import _mxnet_converter as mxnet_converter + +from converter._mxnet_converter import convert Review comment: Does this use the pip installed version of the converter? Would it make more sense to use the version that's in the codebase so that we can catch potential failures in that codebase when a new PR is opened? LMK if I'm misunderstanding this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
