KellenSunderland commented on a change in pull request #11952: [MXNET-707] Add 
unit test for mxnet to coreml converter
URL: https://github.com/apache/incubator-mxnet/pull/11952#discussion_r223987301
 
 

 ##########
 File path: ci/travis/install.sh
 ##########
 @@ -22,5 +22,5 @@ export HOMEBREW_NO_AUTO_UPDATE=1
 
 if [ ${TRAVIS_OS_NAME} == "osx" ]; then
     brew install opencv
-    python -m pip install --user nose numpy cython scipy requests mock 
nose-timer nose-exclude
+    python -m pip install --user nose numpy cython scipy requests mock 
nose-timer nose-exclude mxnet-to-coreml
 
 Review comment:
   Yeah exactly what I'm thinking.  I see adding this check as a two way door 
though.  I'd be ok with adding it per PR (as it runs quite quickly) now, and 
then migrating it when we get Travis setup on nightly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to