KellenSunderland commented on a change in pull request #11952: [MXNET-707] Add
unit test for mxnet to coreml converter
URL: https://github.com/apache/incubator-mxnet/pull/11952#discussion_r223979028
##########
File path: ci/travis/install.sh
##########
@@ -22,5 +22,5 @@ export HOMEBREW_NO_AUTO_UPDATE=1
if [ ${TRAVIS_OS_NAME} == "osx" ]; then
brew install opencv
- python -m pip install --user nose numpy cython scipy requests mock
nose-timer nose-exclude
+ python -m pip install --user nose numpy cython scipy requests mock
nose-timer nose-exclude mxnet-to-coreml
Review comment:
Ok so to summarize, am I understanding this correctly?
(1) What we want to test is that the PyPi version of the converter (which
is in maintenance mode) remains compatible with our codebase as we do things
like changing operator behaviour be it op naming, argument changes (e.g.
default padding), etc. So we're not testing the convert package at all, but
we're really testing for regressions in the operator code that would surface
when trying to do a conversion?
(2) Additionally doing this type of test requires a MacOS environment, not
available for example at the moment as a nightly test, so for these reasons PR
checks are the best homes for this regression test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
