KellenSunderland commented on a change in pull request #12953: Update MKL-DNN
dependency
URL: https://github.com/apache/incubator-mxnet/pull/12953#discussion_r229509685
##########
File path: CMakeLists.txt
##########
@@ -239,8 +239,11 @@ if(USE_MKLDNN)
if(NOT MSVC)
set(ARCH_OPT_FLAGS "-mtune=generic")
endif()
- set(WITH_TEST OFF)
- set(WITH_EXAMPLE OFF)
+ set(WITH_TEST OFF CACHE INTERNAL "" FORCE)
+ set(WITH_EXAMPLE OFF CACHE INTERNAL "" FORCE)
+ set(ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
+
+ include_directories(3rdparty/mkldnn)
Review comment:
Just curious, is there a reason relevant headers aren't in mkldnn/include?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
