KellenSunderland commented on a change in pull request #12953: Update MKL-DNN
dependency
URL: https://github.com/apache/incubator-mxnet/pull/12953#discussion_r229510062
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -88,13 +88,25 @@ mkldnn::convolution_forward::primitive_desc GetConvFwdImpl(
if (param.conv_param.dilate.ndim() == 0 && bias == nullptr) {
mkldnn::convolution_forward::desc desc(prop,
mkldnn::algorithm::convolution_direct,
data_md, weight_md, out_md, strides, padding, padding,
mkldnn::padding_kind::zero);
- return mkldnn::convolution_forward::primitive_desc(desc, attr, engine);
+ auto conv_pd = mkldnn::convolution_forward::primitive_desc(desc, attr,
engine);
+ while (conv_pd.dst_primitive_desc().get_size() != GetArraySize(output) ||
+ conv_pd.src_primitive_desc().get_size() != GetArraySize(data) ||
+ conv_pd.weights_primitive_desc().get_size() !=
GetArraySize(weights)) {
+ CHECK(conv_pd.next_impl()) << "No implementation";
+ }
+ return conv_pd;
Review comment:
Also curious about this. Is this an adaptation to an API change in MKLDNN?
Doe sit return a list of results now rather than a single value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
