KellenSunderland commented on a change in pull request #12953: Update MKL-DNN
dependency
URL: https://github.com/apache/incubator-mxnet/pull/12953#discussion_r229801527
##########
File path: tests/cpp/operator/mkldnn_test.cc
##########
@@ -100,9 +100,9 @@ static void VerifyDefMem(const mkldnn::memory &mem) {
TEST(MKLDNN_UTIL_FUNC, MemFormat) {
// Check whether the number of format is correct.
- CHECK_EQ(mkldnn_format_last, 67);
- CHECK_EQ(mkldnn_nchw, 5);
- CHECK_EQ(mkldnn_oihw, 15);
+ CHECK_EQ(mkldnn_format_last, 110);
+ CHECK_EQ(mkldnn_nchw, 7);
Review comment:
Is there any way we could use enums or consts vars somewhere that would be
able to describe what the integers represent here? It would be interesting for
me to see what memory format 67 used to represent, and the new format 110 means.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
