ciyongch commented on a change in pull request #13000: fix quantize_graph pass
error when there're multiple outputs from a single node
URL: https://github.com/apache/incubator-mxnet/pull/13000#discussion_r234835474
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -156,29 +158,54 @@ Graph QuantizeGraph(Graph &&src) {
new_node->inputs.emplace_back(mirror_entry);
} else if (!NeedQuantize(e.node, excluded_nodes) &&
(mirror_node->op() == nullptr ||
- mirror_node->op()->name != "_contrib_quantize")) {
+ mirror_node->op()->name != "_contrib_quantize") &&
+ (!multiple_outputs_entry_map.count(e))) {
+ // When there're multiple entrys outgoing from a single node, need
to add entry
+ // index (or output name) into quantize/min/max node to distinguish
them.
+ // Or the output name is not ending with 'output', just put the
output name here
+ // to better align with calibration phase. No need to change name to
weights/bias.
+ std::string subfix = "";
Review comment:
Yes, will fix the typo :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
