ciyongch commented on a change in pull request #13000: fix quantize_graph pass
error when there're multiple outputs from a single node
URL: https://github.com/apache/incubator-mxnet/pull/13000#discussion_r234840121
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -156,29 +158,54 @@ Graph QuantizeGraph(Graph &&src) {
new_node->inputs.emplace_back(mirror_entry);
} else if (!NeedQuantize(e.node, excluded_nodes) &&
(mirror_node->op() == nullptr ||
- mirror_node->op()->name != "_contrib_quantize")) {
+ mirror_node->op()->name != "_contrib_quantize") &&
Review comment:
This is the convention naming in current MXNet, right?
For this case, the string name here is already interpretable as either a
constant variable or a function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
