ciyongch commented on a change in pull request #13000: fix quantize_graph pass
error when there're multiple outputs from a single node
URL: https://github.com/apache/incubator-mxnet/pull/13000#discussion_r235262198
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -156,29 +158,54 @@ Graph QuantizeGraph(Graph &&src) {
new_node->inputs.emplace_back(mirror_entry);
} else if (!NeedQuantize(e.node, excluded_nodes) &&
(mirror_node->op() == nullptr ||
- mirror_node->op()->name != "_contrib_quantize")) {
+ mirror_node->op()->name != "_contrib_quantize") &&
Review comment:
Yes, that will be better and more strict way compared with original one.
I'm thinking about checking `entry` (like: `!mirror_entry_map.count(e)`)
but not `mirror_node` here, since we stores the mapping between current entries
and the entries outgoing from `_contrib_quantize` node via
`nnvm::NodeEntryMap<NodeEntry>` for both single output and multiple outputs.
`mirror_node` can handle single output but not multiple outputs, while `entry`
can handle both cases.
What do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
