DickJC123 commented on a change in pull request #13749: Add NHWC layout support
to Pooling (cpu, gpu cuda, gpu cuDNN)
URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r254456709
##########
File path: src/operator/nn/cudnn/cudnn_pooling-inl.h
##########
@@ -125,7 +126,8 @@ class CuDNNPoolingOp {
CHECK_EQ(s->dnn_handle_ownership_, mshadow::Stream<gpu>::OwnHandle);
typename DataType<DType>::ScaleType alpha = 1.0f;
typename DataType<DType>::ScaleType beta = 0.0f;
- this->Init(s, in_data, out_data);
+ if (!this->Init(s, in_data, out_data))
+ LOG(FATAL) << "CuDNN Pooling invoked with unsupported parameters.";
Review comment:
Official name is cuDNN, even at the beginning of a sentence apparently.
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
