DickJC123 commented on a change in pull request #13749: Add NHWC layout support
to Pooling (cpu, gpu cuda, gpu cuDNN)
URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257089824
##########
File path: python/mxnet/gluon/nn/conv_layers.py
##########
@@ -716,7 +718,8 @@ class MaxPool1D(_Pooling):
If padding is non-zero, then the input is implicitly
zero-padded on both sides for padding number of points.
layout : str, default 'NCW'
- Dimension ordering of data and weight. Only supports 'NCW' layout for
now.
+ Dimension ordering of data and weight. Only supports 'NCW' and 'NWC'
+ (only with cuDNN) layouts for now.
Review comment:
Glad you pointed out this ambiguity. I expanded the scope of this work
mid-PR and provided cpu and cuda implementations of the 'transposed' layout
pooling, making these descriptions incorrect. I've changed the text now to be
simpler and correct. Ditto for Symbol's Pooling description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
