anirudh2290 commented on a change in pull request #15285: [WIP] Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#discussion_r295597038
 
 

 ##########
 File path: src/common/directed_graph.h
 ##########
 @@ -0,0 +1,201 @@
+  /*
 
 Review comment:
   Is this PR trying to address: #15198 . My understanding was that this would 
be something on the lines of set_monitor_callback for gluon to monitor 
intermediate nodes in the graph. This seems to be addressing a different 
problem of IR visualization. For the forward pass, the SaveJSON coupled with 
visualization already seems to be doing the trick.(which can be extended for 
backward too if needed) Also , I see TVM has a PrintGraphIR nnvm pass that we 
can leverage. Do we really need this ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to