anirudh2290 commented on a change in pull request #15285: [WIP] Graph dumper URL: https://github.com/apache/incubator-mxnet/pull/15285#discussion_r296928388
########## File path: src/common/directed_graph.h ########## @@ -0,0 +1,201 @@ + /* Review comment: I guess then, the purpose of the PR is to add visualization tool which would directly dump to dot format instead of using the frontend tool to do a followup pass on the symbol json. I think adding so much more code to avoid one line is a bit too much. I am not blocking this though since we are not exposing this to customer but I think it is not needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
