anirudh2290 commented on a change in pull request #15285: [WIP] Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#discussion_r295964816
 
 

 ##########
 File path: src/common/directed_graph.h
 ##########
 @@ -0,0 +1,201 @@
+  /*
 
 Review comment:
   > Good question, the intention is only to dump the graph in Backward to dot 
file or json, so to be precise is only tangential to the original issue. I 
haven't used set_monitor_callback, but from a quick look seems it's bound to an 
executor. How would you use it for backward in imperative? I'm not sure where 
to get an executor in that case.
   
   How to add something set_monitor_callback would require a deepdive but I 
think it would be somewhere in the cached_op. Another question is in gluon 
would you want to monitor the tensors at the block level or the symbol level. 
That also will change things. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to