apeforest commented on a change in pull request #14836: Refactor AGInfo and
Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305019701
##########
File path: src/imperative/imperative.cc
##########
@@ -232,16 +237,13 @@ void Imperative::RecordOp(
node->inputs.resize(inputs.size());
}
- std::vector<bool>& save_inputs = *p_save_inputs;
Review comment:
I feel using these reference is better for readability. Also it's consistent
with line
https://github.com/apache/incubator-mxnet/pull/14836/files#diff-2d0bd6acfa276757ae59106dbed8e3e5R158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
