apeforest commented on a change in pull request #14836: Refactor AGInfo and
Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305028154
##########
File path: src/io/iter_sparse_prefetcher.h
##########
@@ -126,15 +126,15 @@ class SparsePrefetcherIter : public PrefetcherIter {
virtual bool Next(void) {
return PrefetcherIter::Next();
}
- virtual const DataBatch &Value(void) const {
+ virtual const DataBatch& Value(void) const {
return PrefetcherIter::Value();
}
- virtual const NDArrayStorageType GetStorageType(bool is_data) const {
+ virtual NDArrayStorageType GetStorageType(bool is_data) const {
return sparse_loader_->GetStorageType(is_data);
}
- virtual const mxnet::TShape GetShape(bool is_data) const {
+ virtual mxnet::TShape GetShape(bool is_data) const {
Review comment:
Why remove const?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
