apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312265776
##########
File path: src/c_api/c_api_symbolic.cc
##########
@@ -585,76 +585,149 @@ int MXSymbolInferShape(SymbolHandle sym,
API_END();
}
-int MXSymbolInferShapeEx(SymbolHandle sym,
- mx_uint num_args,
- const char** keys,
- const mx_uint *arg_ind_ptr,
- const int *arg_shape_data,
- mx_uint *in_shape_size,
- const int **in_shape_ndim,
- const int ***in_shape_data,
- mx_uint *out_shape_size,
- const int **out_shape_ndim,
- const int ***out_shape_data,
- mx_uint *aux_shape_size,
- const int **aux_shape_ndim,
- const int ***aux_shape_data,
- int *complete) {
- nnvm::Symbol *s = static_cast<nnvm::Symbol*>(sym);
- MXAPIThreadLocalEntry *ret = MXAPIThreadLocalStore::Get();
- API_BEGIN();
+template<typename dtype, typename stype, typename itype>
+inline void SymbolInferShapeImpl(const char** keys,
Review comment:
Also renaming this to SymbolInferShape if you are renaming others too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
