apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312339191
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -105,6 +107,8 @@
_NDARRAY_BASIC_INDEXING = 0
_NDARRAY_ADVANCED_INDEXING = 1
+# Caching whether MXNet was built with INT64 support or not
+_INT64_TENSOR_SIZE_ENABLED = Features().is_enabled('INT64_TENSOR_SIZE')
Review comment:
This is still not efficient as Features() is still called everytime this
variable is evaluated. There is no const variable in Python as in C++
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
