apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r313212202
##########
File path: src/c_api/c_api.cc
##########
@@ -562,6 +580,23 @@ int MXNDArrayGetShapeEx(NDArrayHandle handle,
*out_dim = 0;
}
}
+}
+
+int MXNDArrayGetShapeEx(NDArrayHandle handle,
+ int *out_dim,
+ const int **out_pdata) {
+ MXAPIThreadLocalEntry<> *ret = MXAPIThreadLocalStore<>::Get();
+ API_BEGIN();
+ GetShape<int>(handle, out_pdata, out_dim, ret);
+ API_END();
+}
+
+int MXNDArrayGetShapeEx64(NDArrayHandle handle,
+ int *out_dim,
+ const mx_int64 **out_pdata) {
+ MXAPIThreadLocalEntry<int64_t> *ret = MXAPIThreadLocalStore<int64_t>::Get();
+ API_BEGIN();
+ GetShape<mx_int64>(handle, out_pdata, out_dim, ret);
Review comment:
mx_int64 and int64_t are mixed here. Please consolidate them in your next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
