apache-mynewt-bot commented on pull request #839: URL: https://github.com/apache/mynewt-nimble/pull/839#issuecomment-653219728
<!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### nimble/controller/include/controller/ble_phy_palna.h <details> ```diff @@ -8,10 +8,10 @@ #define BLE_PHY_PALNA_PPI_CHANNEL_RADIO_DISABLED 1 #define BLE_PHY_PALNA_GPIOTE_CHANNEL 0 - void ble_phy_palna_init(void); - void ble_phy_palna_tx_prepare(void); - void ble_phy_palna_rx_prepare(void); - void ble_phy_palna_idle(void); +void ble_phy_palna_init(void); +void ble_phy_palna_tx_prepare(void); +void ble_phy_palna_rx_prepare(void); +void ble_phy_palna_idle(void); #endif #endif ``` </details> #### nimble/drivers/nrf52/src/ble_phy_palna.c <details> ```diff @@ -14,47 +14,52 @@ MODE_RX, } pa_modes_t; -#define PALNA_PPI_CHANNEL_MASK ((1 << BLE_PHY_PALNA_PPI_CHANNEL_RADIO_READY) | (1 << BLE_PHY_PALNA_PPI_CHANNEL_RADIO_DISABLED)) +#define PALNA_PPI_CHANNEL_MASK ((1 << BLE_PHY_PALNA_PPI_CHANNEL_RADIO_READY) | \ + (1 << BLE_PHY_PALNA_PPI_CHANNEL_RADIO_DISABLED)) static void set_mode(pa_modes_t mode); -void ble_phy_palna_init(void) +void +ble_phy_palna_init(void) { - // disable pa, lna + /* disable pa, lna */ #if MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN) - hal_gpio_init_out(MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN), !MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN_ACTIVE_LOW)); - #endif + hal_gpio_init_out(MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN), !MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN_ACTIVE_LOW)); + #endif #if MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN) - hal_gpio_init_out(MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN), !MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN_ACTIVE_LOW)); + hal_gpio_init_out(MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN), !MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN_ACTIVE_LOW)); #endif - //Setup a PPI Channel for Radio Ready Event to enable PA-LNA + /*Setup a PPI Channel for Radio Ready Event to enable PA-LNA */ NRF_PPI->CH[BLE_PHY_PALNA_PPI_CHANNEL_RADIO_READY].EEP = (uint32_t)&NRF_RADIO->EVENTS_READY; NRF_PPI->CH[BLE_PHY_PALNA_PPI_CHANNEL_RADIO_READY].TEP = (uint32_t)&NRF_GPIOTE->TASKS_SET[0]; - //Setup PPI channel for Radio Disabled Event to disable PA-LNA + /*Setup PPI channel for Radio Disabled Event to disable PA-LNA */ NRF_PPI->CH[BLE_PHY_PALNA_PPI_CHANNEL_RADIO_DISABLED].EEP = (uint32_t)&NRF_RADIO->EVENTS_DISABLED; NRF_PPI->CH[BLE_PHY_PALNA_PPI_CHANNEL_RADIO_DISABLED].TEP = (uint32_t)&NRF_GPIOTE->TASKS_CLR[0]; - //init gpiote + /*init gpiote */ nrf_gpiote_te_default(BLE_PHY_PALNA_GPIOTE_CHANNEL); - // off + /* off */ ble_phy_palna_idle(); } -void ble_phy_palna_tx_prepare(void) +void +ble_phy_palna_tx_prepare(void) { set_mode(MODE_TX); } -void ble_phy_palna_rx_prepare(void) +void +ble_phy_palna_rx_prepare(void) { set_mode(MODE_RX); } -void ble_phy_palna_idle(void) +void +ble_phy_palna_idle(void) { set_mode(MODE_SHUTDOWN); } @@ -62,38 +67,39 @@ static void set_mode(pa_modes_t mode) { - NRF_PPI->CHENCLR = PALNA_PPI_CHANNEL_MASK; //disable PPI channels - NRF_GPIOTE->TASKS_CLR[BLE_PHY_PALNA_GPIOTE_CHANNEL] = 1; //ensure current GPIOTE pin is low + NRF_PPI->CHENCLR = PALNA_PPI_CHANNEL_MASK; /*disable PPI channels */ + NRF_GPIOTE->TASKS_CLR[BLE_PHY_PALNA_GPIOTE_CHANNEL] = 1; /*ensure current GPIOTE pin is low */ - switch (mode) - { + switch (mode) { case MODE_SHUTDOWN: nrf_gpiote_te_default(BLE_PHY_PALNA_GPIOTE_CHANNEL); break; case MODE_TX: #if MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN) - nrf_gpiote_task_configure( + nrf_gpiote_task_configure( BLE_PHY_PALNA_GPIOTE_CHANNEL, MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN), NRF_GPIOTE_POLARITY_TOGGLE, - (MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN_ACTIVE_LOW) ? NRF_GPIOTE_INITIAL_VALUE_HIGH : NRF_GPIOTE_INITIAL_VALUE_LOW) - ); + (MYNEWT_VAL(BLE_PHY_PALNA_PA_ENABLE_PIN_ACTIVE_LOW) ? NRF_GPIOTE_INITIAL_VALUE_HIGH : + NRF_GPIOTE_INITIAL_VALUE_LOW) + ); - nrf_gpiote_task_enable(BLE_PHY_PALNA_GPIOTE_CHANNEL); - NRF_PPI->CHENSET = PALNA_PPI_CHANNEL_MASK; //re-enable PPI channels 1 and 2 + nrf_gpiote_task_enable(BLE_PHY_PALNA_GPIOTE_CHANNEL); + NRF_PPI->CHENSET = PALNA_PPI_CHANNEL_MASK; /*re-enable PPI channels 1 and 2 */ #endif case MODE_RX: #if MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN) - nrf_gpiote_task_configure( + nrf_gpiote_task_configure( BLE_PHY_PALNA_GPIOTE_CHANNEL, MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN), NRF_GPIOTE_POLARITY_TOGGLE, - (MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN_ACTIVE_LOW) ? NRF_GPIOTE_INITIAL_VALUE_HIGH : NRF_GPIOTE_INITIAL_VALUE_LOW) - ); - nrf_gpiote_task_enable(BLE_PHY_PALNA_GPIOTE_CHANNEL); - NRF_PPI->CHENSET = PALNA_PPI_CHANNEL_MASK; //re-enable PPI channels 1 and 2 + (MYNEWT_VAL(BLE_PHY_PALNA_LNA_ENABLE_PIN_ACTIVE_LOW) ? NRF_GPIOTE_INITIAL_VALUE_HIGH : + NRF_GPIOTE_INITIAL_VALUE_LOW) + ); + nrf_gpiote_task_enable(BLE_PHY_PALNA_GPIOTE_CHANNEL); + NRF_PPI->CHENSET = PALNA_PPI_CHANNEL_MASK; /*re-enable PPI channels 1 and 2 */ #endif break; } ``` </details> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
