andrzej-kaczmarek commented on pull request #839: URL: https://github.com/apache/mynewt-nimble/pull/839#issuecomment-654099947
not sure if this is the final version or just wip (looks like wip), but few comments to start with: - this needs PR and commit message that explains its purpose and how to use it - do not add APIs to common `controller` headers unless they are generic and can be implemented for other PHYs - we do not use nrfx helpers in nrf5x PHY and I would prefer to keep it this way - check our coding style in existing files and follow it - I do not quite see where new syscfg are defined ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
