donaldschen commented on pull request #839: URL: https://github.com/apache/mynewt-nimble/pull/839#issuecomment-655042737
Hi there, thanks for taking a look at my changes. - this needs PR and commit message that explains its purpose and how to use it. _OK, will update with everything once all the code is firmed up_ - do not add APIs to common controller headers unless they are generic and can be implemented for other PHYs _See next comment_ - we do not use nrfx helpers in nrf5x PHY and I would prefer to keep it this way _Sorry I was a little lost when I added this code in, now it makes a more sense to me now. I will move everything into `drivers/nrf52/...` and move all the `ble_phy_palna...` functions into ble_phy.c._ - check our coding style in existing files and follow it _OK, I'll double check against the coding standard_ - I do not quite see where new syscfg are defined _I'm not entirely sure where to define the syscfg values since they are board specific. The way I am building this with PA/LNA support is with a custom app with the values defined in `apps/myapp/syscfg.yml`_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
