ccollins476ad commented on a change in pull request #279: BLE Host - Policy for 
SM key overflow
URL: 
https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r119370572
 
 

 ##########
 File path: net/nimble/host/src/ble_store.c
 ##########
 @@ -28,49 +28,98 @@ ble_store_read(int obj_type, const union ble_store_key 
*key,
 {
     int rc;
 
+    ble_hs_lock();
 
 Review comment:
   You're right - I snuck it into this PR :).  I do think we need these locks 
here to prevent concurrent reads and writes.  For example, if code is iterating 
the RAM store while a record is being written, a garbage record could be 
retrieved.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to