ccollins476ad commented on a change in pull request #279: BLE Host - Policy for
SM key overflow
URL:
https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r120217422
##########
File path: net/nimble/host/include/host/ble_store.h
##########
@@ -31,6 +31,12 @@ extern "C" {
#define BLE_STORE_OBJ_TYPE_PEER_SEC 2
#define BLE_STORE_OBJ_TYPE_CCCD 3
+/** Failed to persist record; insufficient storage capacity. */
+#define BLE_STORE_EVENT_OVERFLOW 1
+
+/** About to execute a procedure that may fail due to overflow. */
+#define BLE_STORE_EVENT_OVERFLOW_NEXT 2
Review comment:
I don't think BLE_STORE_EVENT_OVERFLOW_NEXT is particularly unclear. It is
so named because the next store operation will overflow. The user may confuse
this event type with the other (BLE_STORE_EVENT_OVERFLOW) because the names are
similar, but I think this is going to be hard to prevent. After all, the
meanings of the events are similar!
If there is a specific name you like, I'm happy to use it. Personally, I am
OK with the current one, or several of the suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
