[ 
https://issues.apache.org/jira/browse/NIFI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988798#comment-14988798
 ] 

Bryan Bende commented on NIFI-274:
----------------------------------

[~tkurc] thanks for getting the latest patch up! A couple of final things...

* TestListenSyslog was failing the TCP tests for me because it wasn't returning 
the actual port that it was listening on. Did this happen to you? I had to 
change the getPort() method on SocketChannelReader to:

{code}
for(SelectionKey key : selector.keys()){
  if (key.isValid()) {
    final Channel channel = key.channel();
      if (channel instanceof  ServerSocketChannel) {
        return ((ServerSocketChannel)channel).socket().getLocalPort();
      }
  }
}
return 0;
{code}

* I realized in my original patch that the default value of the Receive Buffer 
was set to 65507 KB, but I this was supposed to be bytes, not KB.

* While testing this and looking at provenance, I wondered if it would also be 
help to put syslog.protocol and syslog.port as attributes on the outgoing 
FlowFile. I think it would be helpful to go along with the sender to know what 
protocol and port it was received on.

* Do you think we should log the "rejected due to max connections reached" at 
the WARN level instead of info? I only say this from the perspective that the 
user looking at the NiFi UI will really have no way of knowing this is 
happening and may be rejecting incoming data without knowing it. 


> Syslog processors
> -----------------
>
>                 Key: NIFI-274
>                 URL: https://issues.apache.org/jira/browse/NIFI-274
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 0.1.0
>         Environment: any
>            Reporter: Corey Flowers
>            Assignee: Tony Kurc
>            Priority: Minor
>              Labels: features, syslog
>             Fix For: 0.4.0
>
>         Attachments: NIFI-274-2.patch, NIFI-274-3.patch, NIFI-274-4.patch, 
> NIFI-274-5.patch, NIFI-274-6.patch, NIFI-274.patch, SyslogProcessorTesting.xml
>
>
> request to add syslog processors for direct interaction with syslog to 
> include pulls and pushes of log info.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to