[
https://issues.apache.org/jira/browse/NIFI-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992780#comment-14992780
]
ASF GitHub Bot commented on NIFI-1099:
--------------------------------------
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/115#issuecomment-154244035
I started reviewing this. I'm not entirely sure blanket calling interrupt()
is necessarily the right approach. I think some of the InterruptedException
swallowing may be legitimate (e.g. the ShutdownHook). I think @markap14 wrote a
decent part of RunNiFi and the Bootstrap code, he may have thought of the
potential side effects of swallowing those exceptions.
> Interrupted status is not restored
> ----------------------------------
>
> Key: NIFI-1099
> URL: https://issues.apache.org/jira/browse/NIFI-1099
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Fix For: 0.4.0
>
>
> There are few places with code that looks like this
> {code}
> try {
> Thread.sleep(val);
> } catch (InterruptedException ie) {
> }
> {code}
> . . . and the interrupted status of the thread is not restored. Need at the
> very least
> {code}
> Thread.currentThread().interrupt();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
