[ 
https://issues.apache.org/jira/browse/NIFI-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993703#comment-14993703
 ] 

ASF GitHub Bot commented on NIFI-1099:
--------------------------------------

Github user markap14 commented on the pull request:

    https://github.com/apache/nifi/pull/115#issuecomment-154416212
  
    @olegz : Thanks for the link! I've read the book, but it has been many 
years, probably 2-3 years out of college. I could probably learn from reading 
it again, now that I have a much better understanding of Java and concurrency. 
Reading that article was certainly beneficial.
    
    That said, I think to @trkurc's point, in some of the locations (such as 
the bootstrap) it may be okay to swallow and may not need to repeat the 
interrupt... There may also be places that we should in fact being throwing 
InterruptedException ourselves.
    
    While I do agree that the Exception is not being handled properly, we 
should probably review a little more closely rather than performing a blanket 
change to the code.


> Interrupted status is not restored
> ----------------------------------
>
>                 Key: NIFI-1099
>                 URL: https://issues.apache.org/jira/browse/NIFI-1099
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.4.0
>
>
> There are few places with code that looks like this
> {code}
> try {
>    Thread.sleep(val);
> } catch (InterruptedException ie) {
> }
> {code}
> . . . and the interrupted status of the thread is not restored. Need at the 
> very least 
> {code}
> Thread.currentThread().interrupt();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to