[
https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005911#comment-15005911
]
ASF GitHub Bot commented on NIFI-748:
-------------------------------------
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/123#discussion_r44872470
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/LuceneUtil.java
---
@@ -160,4 +162,25 @@ public int compare(final Document o1, final Document
o2) {
}
});
}
+
+ /**
+ * Will group documents based on the {@link
FieldNames#STORAGE_FILENAME}.
+ *
+ * @param documents
+ * list of {@link Document}s
+ * @return a {@link Map} of document groups with
+ * {@link FieldNames#STORAGE_FILENAME} as key and {@link List}
of
+ * {@link Document}s as value.
+ */
+ public static Map<String, List<Document>>
groupDocsByStorageFileName(final List<Document> documents) {
--- End diff --
I like this change. It greatly simplifies the code
> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
> Key: NIFI-748
> URL: https://issues.apache.org/jira/browse/NIFI-748
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Oleg Zhurakousky
> Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can
> be ejected. Disk was accidentally ejected while running. Provenance Event
> appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so
> we can't search on that Component ID at all (unless we shrink the time range
> to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events
> could not be found and show what we can, rather than erroring out entirely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
