[
https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005920#comment-15005920
]
ASF GitHub Bot commented on NIFI-748:
-------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/123#discussion_r44872782
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
---
@@ -47,9 +46,6 @@
public class DocsReader {
private final Logger logger =
LoggerFactory.getLogger(DocsReader.class);
- public DocsReader(final List<File> storageDirectories) {
- }
-
--- End diff --
Should consult the versioning guide to see if it addresses how to handle
this. We need to be very explicit about which parts of the codebase are public
and designed for extension versus those which the community should be free to
evolve . if the guide doesn't cover this case let's solve it.
> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
> Key: NIFI-748
> URL: https://issues.apache.org/jira/browse/NIFI-748
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Oleg Zhurakousky
> Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can
> be ejected. Disk was accidentally ejected while running. Provenance Event
> appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so
> we can't search on that Component ID at all (unless we shrink the time range
> to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events
> could not be found and show what we can, rather than erroring out entirely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
