[ 
https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005937#comment-15005937
 ] 

Tony Kurc commented on NIFI-748:
--------------------------------

[~ozhurakousky] I have to give a +0 from me on this. This is, as [~joewitt] 
points out some pretty critical code, and unfortunately, the prepatch code may 
have had some carefully constructed flow that is not intuitive or commented and 
the patch has altered quite significantly (i.e., not what joe had in mind in 
keeping this in 0.4.0 when he said "But given the trivial nature of the fix" 
above). I think this either needs:

# a review from ideally the original author ([~markap14]?) or someone who has a 
bit more understanding of the decisions made in the pre-patch code
# some evidence that the performance improves?

> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-748
>                 URL: https://issues.apache.org/jira/browse/NIFI-748
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can 
> be ejected. Disk was accidentally ejected while running. Provenance Event 
> appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so 
> we can't search on that Component ID at all (unless we shrink the time range 
> to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events 
> could not be found and show what we can, rather than erroring out entirely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to