[
https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006668#comment-15006668
]
ASF GitHub Bot commented on NIFI-748:
-------------------------------------
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/123#issuecomment-157029989
@trkurc @joewitt @apiri
Guys, please see the latest commit. Didn't squash it, so its easier to read
and see what's been addressed. In summary:
1. Since based on the latest comment from Joe it appears that we all agree
that DocReader is not really public, i kept the dead constructor out and also
made DocReader package private.
2. Based on Tony's point added Document sorting logic back. At least it
will ensure that previous behavior is maintained.
See commit message for more details
> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
> Key: NIFI-748
> URL: https://issues.apache.org/jira/browse/NIFI-748
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Oleg Zhurakousky
> Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can
> be ejected. Disk was accidentally ejected while running. Provenance Event
> appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so
> we can't search on that Component ID at all (unless we shrink the time range
> to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events
> could not be found and show what we can, rather than erroring out entirely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
