[ 
https://issues.apache.org/jira/browse/NIFI-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157457#comment-15157457
 ] 

Joe Skora commented on NIFI-1522:
---------------------------------

Sorry if I'm late to the party, but I agree with Mike on this.

Based on NiFi being more business oriented than consumer oriented, I am 
concerned about unqualified input.  It can be dangerous and often becomes the 
source of unintended errors.  Internationalization can accommodate a great deal 
of flexibility on input and output, done correctly I think it makes thing more 
clear not less because everything is still explicit.  Internationalization 
doesn't require giving anything up in terms of flexibility, input and output 
can support a variety representations and we can still handle input variations 
such as "milli", "micro", "nano", "seconds", "secs", and "s" correctly.

My concerns:
1. Time units are such a fundamental part of a NiFi configuration and 
operation, so it seems like a dangerous place for defaults.
2. Unqualified inputs are often a source of error and can go unnoticed in a 
large system.  I don't think they make things easier for the user.  Further, 
the system will need to track and mark the defaulted values for provenance and 
alert the user in case it is an input error.
3. If a time unit default makes sense, why not a default storage unit or any 
other unit?  The argument for a bytes default sounds very similar to the 
argument for millis.
4. A unit is still needed on output, so a language will still need to be 
configured.  I agree that I won't recognize "1 секунда" or "1秒" as equivalent 
to "1 second", but I also won't recognize "файл потока" or "流文件" in a "flow 
file" label, so excepting a default time in millis won't make the system any 
more usable to me.

> Period and Unit time expressions should default to milliseconds
> ---------------------------------------------------------------
>
>                 Key: NIFI-1522
>                 URL: https://issues.apache.org/jira/browse/NIFI-1522
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Discussion on Github about our current support for period and unit 
> expressions for time 
> https://github.com/apache/nifi/pull/210#discussion_r53167209
> We should support that if a unit of time is not specified that the period is 
> assumed to be in milliseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to