[
https://issues.apache.org/jira/browse/MINIFI-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996836#comment-15996836
]
ASF GitHub Bot commented on MINIFI-258:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114793189
--- Diff: libminifi/src/io/tls/TLSSocket.cpp ---
@@ -31,14 +32,11 @@ namespace nifi {
namespace minifi {
namespace io {
-std::atomic<TLSContext*> TLSContext::context_instance;
-std::mutex TLSContext::context_mutex;
-
-TLSContext::TLSContext()
- : error_value(0),
+TLSContext::TLSContext(std::shared_ptr<Configure> configure)
+ : SocketContext(configure), error_value(0),
ctx(0),
logger_(logging::Logger::getLogger()),
- configuration(Configure::getConfigure()) {
+ configure_(configure) {
--- End diff --
for some reason configure_ seems wrong here. sounds petty but Configure as
the name of the Configuration class seems odd to me.
> Avoid using singleton for Configure.
> -------------------------------------
>
> Key: MINIFI-258
> URL: https://issues.apache.org/jira/browse/MINIFI-258
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
>
> Avoiding a singleton for Configure will allow us to eventually support
> multiple, disparate flows. The object FlowConfiguration can be passed with
> the information in Configure. This has increased coupling dramatically while
> also limiting how configurations can be stored within minifi.
> It stands to reason that to eventually support C2 activities and to
> facilitate multiple configurations, we will need to remove state from the
> global level and make it something that is referenced from the objects which
> care ( proper encapsulation ).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
