[
https://issues.apache.org/jira/browse/MINIFI-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996837#comment-15996837
]
ASF GitHub Bot commented on MINIFI-258:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792218
--- Diff: libminifi/include/core/Processor.h ---
@@ -243,7 +244,7 @@ class Processor : public Connectable, public
ConfigurableComponent,
std::atomic<bool> _triggerWhenEmpty;
//! obtainSite2SiteProtocol for use
--- End diff --
In this case we may want to use a const reference to avoid the need to
increment and decrement the reference counter. This will avoid performance
issues, eventually. This isn't always required, but in places where the
callgraph may enter this function frequently, it's usually good practice.
> Avoid using singleton for Configure.
> -------------------------------------
>
> Key: MINIFI-258
> URL: https://issues.apache.org/jira/browse/MINIFI-258
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
>
> Avoiding a singleton for Configure will allow us to eventually support
> multiple, disparate flows. The object FlowConfiguration can be passed with
> the information in Configure. This has increased coupling dramatically while
> also limiting how configurations can be stored within minifi.
> It stands to reason that to eventually support C2 activities and to
> facilitate multiple configurations, we will need to remove state from the
> global level and make it something that is referenced from the objects which
> care ( proper encapsulation ).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
